-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio tests update, consolidated into one app #2335
Audio tests update, consolidated into one app #2335
Conversation
Useful for inspection if nothing else
@richardeakin I can try to help out with testing on Mac. It's been a few years since I've been involved with a Cinder (or C++) project so I might need some guidance, but let me know if you still need help here. I have a couple Apple devices available for testing. |
Hi @moldybeats thanks for offering to help! Basically the steps I've taken in the past are:
Also, here on some notes about cinder on OS X, they're a bit old now so there might be some minor mods necessary to get the libs and samples built on OS X but I couldn't tell you exactly what as I haven't used an Apple machine for many years now. |
@andrewfb handed me the Mac OS X project files (thanks again!) and I just pushed them to this branch @moldybeats - testing is still welcome if you have the time. I also pushed a change that addressed the Audio Context UI window causing a rare crash, and some decent initial window position settings. |
@richardeakin With those new project files, building & running the AudioTests Xcode project worked great for me. I submitted a PR with fixes for a couple really small issues. Here are a few other things I noticed while clicking around that might be a little harder to pinpoint:
Hope that helps. Let me know if you need more info on any of these. |
Small fixes to rte/audio_tests_update branch
…for reporting)
Thanks @moldybeats for testing! I've addressed the issues you found as well as what was left on my list. The believe I have a fix for the stray |
This PR is a redux of the audio tests I developed when designing the
ci::audio
tools, which were difficult to keep working with so many project files. I've now refactored the tests into one main app that can construct tests based on a string, which is:This also switched the UI from my DIY mini kit to Dear ImGui, which is now part of cinder core (it wasn't when
ci::audio
was initially developed).Remaining Todo List
audio::Context
's auto-pulled nodes, still need to further investigatemason::Factory
that I've used in many projects to create sub-classed ('factory') classes based on a string. Need to figure out where this should live, I'd like it to be a header-only class in cinder core but there is more debate around how generic a factory tool within cinder core should be.MonitorNode
s after switching through tests multiple timesHere's what one of the tests (
WaveTable
) looks like: