Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pde petrinet model to tests/fixtures #490

Closed
wants to merge 2 commits into from

Conversation

sabinala
Copy link
Contributor

Closes #489

@sabinala sabinala requested a review from SamWitty February 21, 2024 18:26
@sabinala sabinala linked an issue Feb 21, 2024 that may be closed by this pull request
@SamWitty
Copy link
Contributor

@sabinala , what is the status of this PR? I see you assigned me as a reviewer, but there are no tags denoting that it's ready for review and the tests are failing.

@sabinala sabinala removed the request for review from SamWitty February 21, 2024 19:34
@sabinala
Copy link
Contributor Author

@SamWitty sorry, I should have waited for the tests to pass before assigning you. This PR is just adding that pde petrinet model as a model fixture in tests/fixtures.py, just want to make sure, that is what you were asking me to do in your comment in #487 ?

@SamWitty
Copy link
Contributor

Thanks! I've subsumed this by #491 to test whether my "fix" works.

@SamWitty SamWitty closed this Feb 21, 2024
@sabinala sabinala deleted the 489-adding-pde-petrinet-to-tests branch February 21, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding pde petrinet to tests
2 participants