forked from jhclark/multeval
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make multeval.sh run from arbitrary working directory
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba7c703
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that look for a file named
constants
at the root directory instead?I think it's cleaner to bake the version number in at compile time using the manifest, but I'm not really sure the Java code and manifest I posted are production-ready
ba7c703
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Not in the root directory of the system, but in the root(s) of the classpath.
Your fix solves the bug as well, through baking the version into the JAR. That avoids having to point to $scriptDir itself in the classpath in multeval.sh. I think that one should be a no-brainer merge request.