Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored to extract locales from Python dictionaries to JSON files #221

Merged
merged 15 commits into from
Sep 7, 2023
Merged

Refactored to extract locales from Python dictionaries to JSON files #221

merged 15 commits into from
Sep 7, 2023

Conversation

cicirello
Copy link
Owner

Summary

Extracted locales (e.g., all string data defining labels and headings, etc) from Python dictionaries into JSON files. PR also includes other minor editing for formatting, etc.

Closing Issues

Closes #220

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvements to existing code, such as refactoring or optimizations (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cicirello cicirello merged commit 53bb18e into main Sep 7, 2023
3 checks passed
@cicirello cicirello deleted the refactor branch September 7, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract locales from Python dictionaries to JSON
1 participant
@cicirello