Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci-group package renaming #569

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Ci-group package renaming #569

merged 8 commits into from
Sep 11, 2024

Conversation

andresgr96
Copy link
Contributor

@andresgr96 andresgr96 commented Sep 9, 2024 •
edited
Loading

  • Renamed ci-group package to "standards" for clarity
  • Updated docs to reflect the change above
  • Edited the first example to include an advice to go over that package
  • Fixes [BUG] Example 1B not running #570

@andresgr96 andresgr96 requested a review from JedMuff September 9, 2024 13:31
@tckarenchiang tckarenchiang self-assigned this Sep 11, 2024
@tckarenchiang tckarenchiang self-requested a review September 11, 2024 10:54
@tckarenchiang tckarenchiang removed their assignment Sep 11, 2024
@tckarenchiang
Copy link
Contributor

The changes look fine, but I think there is a bug when running examples/1_simulator_basics/1b_custom_terrain/main.py. I got the following error:

File "/home/karen/.venv_revolve2_dev/lib/python3.10/site-packages/dm_control/mjcf/attribute.py", line 193, in _assign
    raise ValueError('Expect keyword to be one of {} but got: {}'.format(
ValueError: during initialization of attribute 'type' of element <texture>: Expect keyword to be one of ['2d', 'cube', 'skybox'] but got: 1

I think the texture/type attribute expects a string, not an integer. See here: https://mujoco.readthedocs.io/en/stable/XMLreference.html#asset-texture

andresgr96
andresgr96 commented Sep 11, 2024
View reviewed changes
Copy link
Contributor Author

@andresgr96 andresgr96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I added a bug report yesterday about this #570

@andresgr96 andresgr96 self-assigned this Sep 11, 2024
@andresgr96 andresgr96 merged commit 95a423b into development Sep 11, 2024
64 checks passed
@andresgr96 andresgr96 deleted the rename branch September 11, 2024 14:20
andresgr96 added a commit that referenced this pull request Sep 13, 2024
@andresgr96 @tckarenchiang
Ci-group package renaming (#569)
13492b0 
* renamed ci-group folder, updated docs and first example

* Fix texture type bug: the texture/type attribute expects a string, not an integer

* Reformat the strings with double quotes

* Fix the format

* Remove the unused method

---------

Co-authored-by: Andres <[email protected]>
Co-authored-by: Ting-Chia Chiang <[email protected]>
@andresgr96 andresgr96 mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tckarenchiang tckarenchiang tckarenchiang approved these changes

@JedMuff JedMuff Awaiting requested review from JedMuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresgr96 @tckarenchiang