-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Docker image to function with current HEAD and upstream wego #614
base: master
Are you sure you want to change the base?
Conversation
- Use debian buster based images due to the terrible availability of alpine compatible wheels and ansi2html failing under alpine. - Automate fetching of airport.dat & GeoLite2 but an API key must be passed at image build time - Also include upstream wego in the image since it supports more backends that still provide personal API keys. - Rewrite wego compatibility back to upstream wego. Ideally there should be a config option to use the fork or upstream and to change the wego param --location/--city based on it.
Very cool contribution! Thank you. Several questions:
|
|
Bumping this.. I would like to use docker but it currently seems a bit outdated. Is this PR still valid? |
Let me do a thorough check later if I can sanely rebase this up to date, but pretty sure this is what I'm running in prod. |
Having dug into this again, there's a lot of work to do unfortunately. The codebase has had large changes again without updating the Dockerfile at all, so it seems @chubin is not running their prod instance on Docker since the codebase is anything but hermetic and relies on static paths to resources such as I'll try to create side by side a new PR that adds in the necessary overrides to make the codebase work in a hermetic environment and then drag the Dockerfile up to speed to run said hermetic environment. Ultimately though this will be a futile effort in the long run as long as Igor runs his production in a non-hermetic way and evolves the codebase with that in mind and without testing the code on Docker. |
alpine compatible wheels and ansi2html failing under alpine.
passed at image build time
backends that still provide personal API keys.
be a config option to use the fork or upstream and to change the wego
param --location/--city based on it.