Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify publish ci #189

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

acrrd
Copy link
Contributor

@acrrd acrrd commented Jan 7, 2025

Step Verify cargo publish includes all files needed to build is failing with:

error: crates-io is replaced with non-remote-registry source dir chrono-tz/vendor;
include `--registry crates-io` to use crates.io

The error appears only with cargo 1.82 and greater.

Passing --registry crates-io is not a solution because it is a nightly-only option.

Calling cargo publish -p <name> for each crate solves the problem.

Step `Verify cargo publish includes all files needed to build` is
failing with:
```
error: crates-io is replaced with non-remote-registry source dir chrono-tz/vendor;
include `--registry crates-io` to use crates.io
```

The error appears only with cargo 1.82 and greater.

Passing `--registry crates-io` is not a solution because it a nightly-only option.

Calling `cargo publish -p <name>` for each crate solves the problem.
@acrrd
Copy link
Contributor Author

acrrd commented Jan 7, 2025

The cargo changelog for 1.82 mentions a few fixes and changes for cargo publish.
In particular, this (rust-lang/cargo#13947) is the first PR that introduces --registry in nightly so this behaviour could be a side effect of that or later PRs.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@djc djc added this pull request to the merge queue Jan 7, 2025
Merged via the queue into chronotope:main with commit 16279f8 Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants