-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement new customizable select value mapping
The new behavior was discussed and chosen here: openui/open-ui#1117 Fixed: 380313544 Change-Id: I1040340f49eb202a84f738c564dabb47a12f3bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203726 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1415636}
- Loading branch information
1 parent
2171020
commit 009cd7d
Showing
35 changed files
with
259 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/event/menulist-custom-expand-collapse-expected-mac.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
AXExpandedChanged on AXPopUpButton AXDescription='Fruit' AXValue='Apple' | ||
AXExpandedChanged on AXPopUpButton AXDescription='Fruit' AXValue='^' | ||
AXFocusedUIElementChanged on AXMenuItem AXValue='Apple' | ||
AXMenuItemSelected on AXMenuItem AXValue='Apple' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
content/test/data/accessibility/html/custom-select-button-value-expected-auralinux.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[document web] | ||
++[section] | ||
++++[combo box] | ||
++++++[menu] | ||
++++++++[menu item] name='option' selectable selected |
11 changes: 11 additions & 0 deletions
11
content/test/data/accessibility/html/custom-select-button-value-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
rootWebArea | ||
++genericContainer ignored | ||
++++genericContainer | ||
++++++comboBoxSelect collapsed value='button' | ||
++++++++genericContainer ignored invisible | ||
++++++++++button ignored invisible | ||
++++++++++++staticText ignored invisible | ||
++++++++++++genericContainer ignored invisible | ||
++++++++++++++staticText ignored invisible | ||
++++++++menuListPopup invisible ispopup=auto | ||
++++++++++menuListOption name='option' selected=true |
12 changes: 12 additions & 0 deletions
12
content/test/data/accessibility/html/custom-select-button-value.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!DOCTYPE html> | ||
<style> | ||
select, ::picker(select) { | ||
appearance: base-select; | ||
} | ||
</style> | ||
<select> | ||
<button>button | ||
<span aria-hidden=true>aria hidden span</span> | ||
</button> | ||
<option>option</option> | ||
</select> |
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-expected-android.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
content/test/data/accessibility/html/custom-select-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
content/test/data/accessibility/html/custom-select-expected-fuchsia.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-expected-mac.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-expected-uia-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Document | ||
++Group IsControlElement=false | ||
++++ComboBox Name='Currency for purchase' ExpandCollapse.ExpandCollapseState='Collapsed' Value.Value='USD United States Dollar $' | ||
++++ComboBox Name='Currency for purchase' ExpandCollapse.ExpandCollapseState='Collapsed' Value.Value='USD' |
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-expected-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE | ||
++IA2_ROLE_SECTION | ||
++++ROLE_SYSTEM_COMBOBOX name='Currency for purchase' value='USD United States Dollar $' COLLAPSED FOCUSABLE HASPOPUP haspopup:menu | ||
++++ROLE_SYSTEM_COMBOBOX name='Currency for purchase' value='USD' COLLAPSED FOCUSABLE HASPOPUP haspopup:menu |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
content/test/data/accessibility/html/custom-select-img-alt-expected-auralinux.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[document web] | ||
++[section] | ||
++++[combo box] | ||
++++++[menu] | ||
++++++++[menu item] name='option without img' selectable selected | ||
++++++++[menu item] name=' option with img with alt img alt text' selectable | ||
++++++++++[static] name='<newline> option with img with alt<newline> ' | ||
++++++++++[image] name='img alt text' | ||
++++++++[menu item] name=' option with img without alt ' selectable | ||
++++++++++[static] name='<newline> option with img without alt<newline> ' | ||
++++++++++[image] |
18 changes: 18 additions & 0 deletions
18
content/test/data/accessibility/html/custom-select-img-alt-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
rootWebArea | ||
++genericContainer ignored | ||
++++genericContainer | ||
++++++comboBoxSelect collapsed value='option without img' | ||
++++++++genericContainer ignored invisible | ||
++++++++++button ignored invisible | ||
++++++++++++genericContainer ignored invisible | ||
++++++++++++++staticText ignored invisible | ||
++++++++menuListPopup invisible ispopup=auto | ||
++++++++++menuListOption name='option without img' selected=true | ||
++++++++++menuListOption invisible name=' option with img with alt img alt text' selected=false | ||
++++++++++++genericContainer ignored invisible | ||
++++++++++++++staticText invisible name='<newline> option with img with alt<newline> ' | ||
++++++++++++++image invisible name='img alt text' | ||
++++++++++menuListOption invisible name=' option with img without alt ' selected=false | ||
++++++++++++genericContainer ignored invisible | ||
++++++++++++++staticText invisible name='<newline> option with img without alt<newline> ' | ||
++++++++++++++image invisible |
23 changes: 23 additions & 0 deletions
23
content/test/data/accessibility/html/custom-select-img-alt.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<!DOCTYPE html> | ||
<style> | ||
select, ::picker(select) { | ||
appearance: base-select; | ||
} | ||
</style> | ||
|
||
<select> | ||
<button> | ||
<selectedcontent></selectedcontent> | ||
</button> | ||
<option> | ||
option without img | ||
</option> | ||
<option> | ||
option with img with alt | ||
<img alt="img alt text"> | ||
</option> | ||
<option> | ||
option with img without alt | ||
<img> | ||
</option> | ||
</select> |
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-open-expected-android.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
content/test/data/accessibility/html/custom-select-open-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
content/test/data/accessibility/html/custom-select-open-expected-fuchsia.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-open-expected-mac.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-open-expected-uia-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/custom-select-open-expected-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.