generate bindings during build #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bartek, could you review this patch? |
bgrzesik
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Hi! I understand your take on this and in ideal world I would also love to handle this in this manner. However I do have few concerns:
- Not all build systems do support cargo build scripts. To name one, an Android Soong is good example. In Soong's case generating a bingings during build time would have to be done in a separate crate. This way we can keep everything in one crate.
- With switch to generation of the bindings during build time, the missing symbols would cause compile errors rather then linking errors. IMHO the later is much more favored in case of libraries, because the use case defines if it is critical.
- It is rather a nit, however having a generated bingings in a commit diff, allows verification if the bingings have just only upreved and continue to be "fresh"
.github/workflows/rust.yml
Outdated
| - name: "Check out libva" | ||
| run: | | ||
| curl -O -L https://github.com/intel/libva/releases/download/2.22.0/libva-2.22.0.tar.bz2 && \ | ||
| tar xf libva-2.22.0.tar.bz2 --one-top-level=work --strip-components 1 |
There was a problem hiding this comment.
Is there a reason why not use apt install libva-devel?
added 14 commits
October 18, 2024 20:21
This reverts commit b2bcd8d.
bgrzesik
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.