Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra Basic Authentication tests in E2E #194

Conversation

andrewortwein
Copy link
Contributor

Issue: #AP-4963

What Changed

There are now two resources that require authentication: /protected and /admin. These resources use different sets of credentials to access them. This ensures that credentials set in a specific test will override global credentials, as supported in Playwright.

There is also a new Cypress test to validate that tests can set credentials to access these protected resources.

How to test

See the Cypress and Playwright auth tests.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e629f2b) 294 280 95.24%
Head commit (f4b5c86) 294 (+0) 280 (+0) 95.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#194) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewortwein nice work, thanks for adding these!

@andrewortwein andrewortwein merged commit d13a446 into main Sep 4, 2024
11 checks passed
@andrewortwein andrewortwein deleted the andrew/ap-4963-add-extra-basic-authentication-tests-in-e2e-to-ensure-we branch September 4, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants