-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[ENH] Make rank expr operational in search api #5429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] Make rank expr operational in search api #5429
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Refactor and Generalize Search Ranking: Make RankExpr Optional/Operational in Search API This PR performs a significant rework of the search API's ranking mechanism, transitioning from a required, enum-based Key Changes• Replaces the flat enum-based Rank with a new struct Affected Areas• Rust backend execution (operator.rs, plan.rs, orchestration/rank.rs, operators/rank.rs, server.rs) This summary was automatically generated by @propel-code-bot |
dd5e08b
to
23549e6
Compare
8828057
to
7f942e7
Compare
a481117
to
bc8df61
Compare
7f942e7
to
a02da4a
Compare
bc8df61
to
1cb2444
Compare
a02da4a
to
dcb9b49
Compare
1cb2444
to
832e8cd
Compare
Description of changes
Summarize the changes made by this PR.
None
rank expression, in which case the the search behaves as if it is aget
.Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?