Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dns lookup passing full url to website instead of domain #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s0m31-hub
Copy link

@s0m31-hub s0m31-hub commented Aug 29, 2023

Now, when View DNS records feature is used only domain will be passed to lookup website

@s0m31-hub
Copy link
Author

p.s. I am not really a frontend developer.

In ideal world, this fix should be rewritten in a separate function. But it will work fine in most cases for now

@chrispederick
Copy link
Owner

Thanks for the pull request! Ideally I want to fix this as part of adding standard support for domains vs. URLs which is on the to-do list:

https://chrispederick.com/work/web-developer/to-do/#item-4E5F8488-FD05-417A-B902-AE6B1667322D

That will be more robust than trying to match based on the URL of the tool, but I'll leave this PR open until I get the chance to work on this.

@lapervenche
Copy link

🇬🇧
For years I have been using your software.
I translated this one in my mother tongue French but impossible then to share it with the community.

  • In Google Chrome no problem for French to be supported, it works 100%

  • In Firefox (the main browser at home) impossible to pass your software in French and yet it works without any concern in debugging mode.

I would so much like to offer you my work but I do not know how to transform into .xpi the basic folder in which I added the "FR_FR" folder and inside the "messages.json" file fully translated.

How can I offer you all this to thank you for inventing Web Developer which has been doing so many service for many for so many years.

🇲🇫 In french:
Depuis des années j'utilise votre soft.
J'ai traduit celui ci dans ma langue maternelle le francais mais impossible ensuite d'en faire profiter la communauté.
-- Dans Google Chrome aucun problème pour que le français soit pris en charge, ça fonctionne à 100%

  • Dans Firefox (le navigateur principal chez moi) impossible de passer votre logiciel en Français et pourtant il fonctionne sans aucun souci en mode débogage.

J'aimerais tant vous offrir mon travail mais je ne sais pas comment faire pour transformer en .xpi le dossier de base dans lequel j'ai ajouté le dossier "fr_FR" et dedans le fichier "messages.json" entièrement traduit.

Comment puis je vous offrir tout ceci pour vous remercier d'avoir inventé Web Developer qui rend tant de service à beaucoup depuis tant d'années.

2

traduit

original

@chrispederick
Copy link
Owner

I am working on some major updates to the extension and plan on looking into localization options after that is done. Once I have more details I'll post an update and ask for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants