Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Build status updates: 3.10 stable #42

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

absalomedia
Copy link

Build sequence now tested on Docker & Travis, with latest HHVM builds. Works with 3.10.x

@absalomedia absalomedia changed the title Build status updates Build status updates: 3.10 stable Dec 7, 2015
@paullryan
Copy link

I can verify this works with 3.11.0 as well.
@chregu any thoughts on merging?

@gorbunovav
Copy link

@paullryan hi! do you see transactions with 3.11 and this patch ? All my transactions are displayed as "Root path" (in APM).

@absalomedia
Copy link
Author

@gorbunovav New Relic may not support setting of dynamic / individual transaction names, according to what I can make of this https://discuss.newrelic.com/t/how-does-the-nr-agent-determine-a-transaction/32867/2

@gorbunovav
Copy link

@absalomedia hmm... I had 3.5.1 before update and some version of this extension from the same date, and I've seen transactions as normal urls.
Right after update I've started to see everything as "Root path". There is no any additional info about transactions also, despite I was enabling function level & external services profiling.
I run standard php application (Magento store actually) and I have seo-friendly urls, with everything rewritten to index.php, as usual.

@gorbunovav
Copy link

@absalomedia I've added
newrelic_name_transaction($_SERVER['REQUEST_URI']);
and now I have transactions named after uris, but there is still no profiling information at all (everything is shown as WebTransaction)

@gorbunovav
Copy link

@absalomedia I've played with the old version a little. I think I was not correct - trace/profiling data are in place. What I am missing are segments in breakdown table, but it looks, that old version was not filling them too.
So it is not issue of this patch.
The only difference with the old version, which I see, is automatic transaction naming after URIs.
Otherwise I can confirm, that it works ok with HHVM 3.11.1

@dieend
Copy link

dieend commented Feb 26, 2016

Does this works for 3.12?

@absalomedia
Copy link
Author

@dieend it should. I confirmed builds on 3.10 & 3.11 without issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants