Podspec #44
Open
Podspec #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungilation
suggested changes
Jul 24, 2019
ToolTipMenu.podspec
Outdated
| s.homepage = package['repository']['url'] | ||
| s.platform = :ios, "10.0" | ||
| s.ios.deployment_target = '10.0' | ||
| s.tvos.deployment_target = '10.0' |
There was a problem hiding this comment.
Thanks for this PR and your fork! Needed on RN 0.60 as it's requiring pods as default, and packages not using pods run into 'React/RCTViewManager.h' file not found issues.
However, your ios target version of 10.0 is higher than need be. On running pod update, I get this error:
[!] CocoaPods could not find compatible versions for pod "ToolTipMenu":
In Podfile:
ToolTipMenu (from `../node_modules/react-native-tooltip`)
Specs satisfying the `ToolTipMenu (from `../node_modules/react-native-tooltip`)` dependency were found, but they required a higher minimum deployment target.
I patch-package'ed your fork to delete the above 2 lines with deployment_target, and changed s.platform to 9.0. Like https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec as reference podspec. Then pod update runs fine.
|
This ready to go @chirag04 @fungilation ? Seeing warnings about this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.