Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cert tweaks to names and TCB info #1725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cert tweaks to names and TCB info #1725

wants to merge 1 commit into from

Conversation

nquarton
Copy link
Contributor

No description provided.

@nquarton nquarton linked an issue Oct 18, 2024 that may be closed by this pull request
DICE: Minor Changes required to TCBInfo Sections of FMC_ALIAS / RT_ALIAS #1696
Open
@nquarton nquarton added ROM Issue affects ROM FMC Issues affects FMC labels Oct 18, 2024
@nquarton nquarton mentioned this pull request Oct 18, 2024
Open
@nquarton nquarton marked this pull request as ready for review October 30, 2024 21:24
jhand2
jhand2 reviewed Oct 30, 2024
View reviewed changes
rom/dev/src/flow/cold_reset/fmc_alias.rs
@@ -252,6 +252,6 @@ impl FmcAliasLayer {
flags |= dice::FLAG_BIT_DEBUG;
}

flags.to_be_bytes()
flags.reverse_bits().to_be_bytes()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the bits need to be reversed? The constants seem to match the spec.

test/tests/caliptra_integration_tests/smoke_testdata/rt_alias_cert_redacted.txt
@@ -30,7 +30,7 @@ Certificate:
2.23.133.5.4.4:
0....................
2.23.133.5.4.1:
DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD
DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the change that leads to the TCBInfo extension being shorter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 left review comments

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@wmaroneAMD wmaroneAMD Awaiting requested review from wmaroneAMD wmaroneAMD is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@jlmahowa-amd jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@FerralCoder FerralCoder Awaiting requested review from FerralCoder FerralCoder is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
FMC Issues affects FMC ROM Issue affects ROM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DICE: Minor Changes required to TCBInfo Sections of FMC_ALIAS / RT_ALIAS
2 participants
@nquarton @jhand2