Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more linters #8

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

bradenhilton
Copy link
Member

This might not work right away...

@bradenhilton
Copy link
Member Author

For info, if this is merged and works well, we could consider also using it for chezmoi, given that the repo contains Go/Markdown/Python/PowerShell/Shell/YAML/etc. files.

@twpayne
Copy link
Member

twpayne commented Feb 27, 2024

I'd rather configure individual linters than use MegaLinter. Reasons:

  • We can update individual linters more easily, instead of having to wait for MegaLinter bulk updates. It's easier to stay on top of multiple small changes than a few, occasional large ones.
  • Totally subjective, but MegaLinter is just so terribly ugly. Its config files, its output, its interface... It makes my eyes hurt.
  • Biased, but I don't want to have to install NodeJS on any of my systems due to npm hell and NodeJS regularly breaking backwards compatibility.

@bradenhilton
Copy link
Member Author

@twpayne Valid points. Would you prefer if rework this PR to use individual linters?

The markdown linter is there because I have some (rough) initial documentation ready.

@twpayne
Copy link
Member

twpayne commented Feb 27, 2024

Would you prefer if rework this PR to use individual linters?

Yes please!

Also, please consider adding the Markdown linters to twpayne/chezmoi.

@bradenhilton bradenhilton changed the title chore: Use MegaLinter chore: Add more linters Feb 27, 2024
Copy link
Member

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bradenhilton bradenhilton merged commit 6a8f2f0 into chezmoi:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants