Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add replaceAll #18

Merged
merged 1 commit into from
May 18, 2024
Merged

feat: Add replaceAll #18

merged 1 commit into from
May 18, 2024

Conversation

twpayne
Copy link
Member

@twpayne twpayne commented Mar 5, 2024

No description provided.

@twpayne twpayne changed the title feat: add replaceAll feat: Add replaceAll Mar 5, 2024
bradenhilton
bradenhilton approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@bradenhilton bradenhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a plan to merge this at some point?

Should it be promoted to proper named function?

@twpayne twpayne force-pushed the replace-all branch 2 times, most recently from e7c7cac to 6d3a0e9 Compare May 18, 2024 14:53
@twpayne
Copy link
Member Author

twpayne commented May 18, 2024

Oops I forgot about this. Updated PR to promote function.

@twpayne twpayne merged commit 7bbc981 into master May 18, 2024
2 checks passed
@twpayne twpayne deleted the replace-all branch May 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradenhilton bradenhilton bradenhilton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twpayne @bradenhilton