Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.py to catch 400 error #722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rockystone77
Copy link

@rockystone77 rockystone77 commented Jul 1, 2024

This would stop the no header situation expectations to go upstream to ssl. So catch it here.

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • [ x] πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

Resolves #

❓ What is the current behavior? (You can also link to an open issue here)
The error is not caught and is handled.

❓ What is the new behavior (if this is a feature change)?
The error is handled and not taken upstream to raise an unhandled error.

πŸ“‹ Other information:

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

This would stop the no header situation so catch it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant