fix: remove redundant std::move for a local object in a return statement

chenshuo · Dec 2, 2019 · 0f3cb97 · 0f3cb97
1 parent 0edc4c9
commit 0f3cb97
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/muduo/base/BlockingQueue.h b/muduo/base/BlockingQueue.h
@@ -52,7 +52,7 @@ class BlockingQueue : noncopyable
     assert(!queue_.empty());
     T front(std::move(queue_.front()));
     queue_.pop_front();
-    return std::move(front);
+    return front;
   }
 
   size_t size() const

diff --git a/muduo/base/BoundedBlockingQueue.h b/muduo/base/BoundedBlockingQueue.h
@@ -62,7 +62,7 @@ class BoundedBlockingQueue : noncopyable
     T front(std::move(queue_.front()));
     queue_.pop_front();
     notFull_.notify();
-    return std::move(front);
+    return front;
   }
 
   bool empty() const