Remove delta comparison for fillup #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to let the DB compare the level to the capacity (using it's own float representation) and to return based on that. Since we use LEAST the value would be equal (exactly) to capacity at overflow. Closes #7
|
Since we have a changelog, it would be great if we can document this change there as well. |
skatkov
reviewed
Nov 30, 2023
lib/pecorino/leaky_bucket.rb
Outdated
| # correctly, thus the clock_timestamp() value would be frozen between calls. We don't want that here. | ||
| # See https://stackoverflow.com/questions/73184531/why-would-postgres-clock-timestamp-freeze-inside-a-rails-unit-test | ||
| level_after_fillup = conn.uncached { conn.select_value(sql) } | ||
| upserted = conn.uncached { conn.select_one(sql) } | ||
| capped_level_after_fillup, did_fillup = upserted.fetch("level"), upserted.fetch("did_fillup") |
There was a problem hiding this comment.
Variable naming makes me a bit cringe here.
Can I suggest did_fillup => is_filled or is_full and capped_level_after_fillup => adjusted_level?
There was a problem hiding this comment.
The naming is very deliberate, did_fillup is a better tense than is_filled (it denotes a definite transition of state, i.e. "something did take place"). We can alternatively use did_overflow if you would prefer that. adjusted_level is not a good name because it assumes there is "some kind of adjustment", whereas "capped" (or "clamped") tells the reader what kind of adjustment has been done.
skatkov
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to let the DB compare the level to the capacity (using it's own float representation) and to return based on that. Since we use LEAST the value would be equal (exactly) to capacity at overflow.
Closes #7