Proper Struct syntax #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for addition. Can you add a CHANGELOG entry as well, please? |
bdewater
force-pushed
the
fix-structs
branch
from
f50915d to
cc0516d
Compare
|
@skatkov done :) |
Struct.new already subclasses, the other syntax creates an anonymous subclcass in the ancestor chain and makes Tapioca overlook the setters/getters defined in the arguments when generating signatures
bdewater
force-pushed
the
fix-structs
branch
from
cc0516d to
58121e4
Compare
|
Great. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct.new already subclasses, the other syntax creates an anonymous subclcass in the ancestor chain and makes Tapioca overlook the setters/getters defined in the arguments when generating signatures (Shopify/tapioca#1384)