Add rails 8 support #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanhesteren
force-pushed
the
rails-8-support
branch
from
08df7ad to
9612d9e
Compare
svanhesteren
force-pushed
the
rails-8-support
branch
from
9612d9e to
4ed6835
Compare
julik
requested changes
Dec 20, 2024
| @@ -30,10 +30,10 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| # Uncomment to register a new dependency of your gem | |||
| spec.add_dependency "activerecord", "~> 7" | |||
| spec.add_dependency "activerecord", "~> 8" | |||
There was a problem hiding this comment.
Let's make both of these development dependencies instead of runtime dependencies. This gem should work fine even with Rails 6 but you would need to set up Appraisal to run the tests on GH actions for this. If we make AR ~> 8 a hard dependency people won't be able to use Pecorino with Rails 7 anymore.
Alternatively, we can set >= 7, < 9 as constraints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.