Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destroy instances created by jenkins jobs, but not cleanly destroyed #1239

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

destroy instances created by jenkins jobs, but not cleanly destroyed #1239

wants to merge 2 commits into from

Conversation

addyess
Copy link
Member

@addyess addyess commented Mar 20, 2023

No description provided.

@Cynerva
Copy link
Contributor

Cynerva commented Mar 20, 2023

I would put an explicit check somewhere in here that the vmfolder is k8s-ci-root. An accidental deletion of all VMs in any other folder could be catastrophic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @Cynerva