New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for https #4

Open

Santosh-Coupa wants to merge 3 commits into chaostoolkit-incubator:master from Santosh-Coupa:master

Santosh-Coupa commented Nov 24, 2021

Whenever using https we need to use url": "https://example.com" its working as expected

Santosh-Coupa added 3 commits

November 24, 2021 14:55


          Update utils.py

a6fcb97


          Update driver.py

cf89ef8


          Merge pull request #1 from Santosh-Coupa/patch-1

61a7499

Update driver.py

ciaransweet commented Nov 29, 2021

@Santosh-Coupa - Thanks for the PR! Your DCO check is failing, you can see how to remedy it here: https://github.com/chaostoolkit-incubator/chaostoolkit-wiremock/pull/4/checks?check_run_id=4310368163 Also - I think verify would better be provided as a parameter, where the default is true. Not everyone will want to not verify HTTPS calls.

@Lawouach I'm not sure if we want to also look at adding some more contribution checks around this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet