fix for newer ctk lib + urllib3 instrumentation

Signed-off-by: Sylvain Hellegouarch <[email protected]>
chaostoolkit-incubator · Aug 2, 2023 · a7d44fb · a7d44fb
1 parent 27d93dd
commit a7d44fb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,14 @@
 
 [Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-opentracing/compare/0.12.0...HEAD
 
+### Added
+
+- Automatic tracing of urllib3
+
+### Changed
+
+- Do not explicitly call tracing on activities, chaoslib does it for us now
+
 ## [0.12.0][] - 2023-08-02
 
 [0.12.0]: https://github.com/chaostoolkit-incubator/chaostoolkit-opentracing/compare/0.11.0...0.12.0

diff --git a/chaostracing/oltp.py b/chaostracing/oltp.py
@@ -87,8 +87,6 @@
 
 __all__ = [
     "configure_control",
-    "before_activity_control",
-    "after_activity_control",
 ]
 
 REGISTRY_HANDLER = None
@@ -114,25 +112,6 @@ def configure_control(
     REGISTRY_HANDLER.started(experiment, None)
 
 
-def before_activity_control(
-    context: Activity,
-    configuration: Configuration = None,
-    secrets: Secrets = None,
-    **kwargs: Any,
-) -> None:
-    REGISTRY_HANDLER.start_activity(context)
-
-
-def after_activity_control(
-    context: Activity,
-    state: Run,
-    configuration: Configuration = None,
-    secrets: Secrets = None,
-    **kwargs: Any,
-) -> None:
-    REGISTRY_HANDLER.activity_completed(context, state)
-
-
 class OLTPRunEventHandler(RunEventHandler):
     def __init__(self) -> None:
         self.root_stack = None

diff --git a/requirements.txt b/requirements.txt
@@ -1,4 +1,4 @@
-chaostoolkit-lib~=1.33
+chaostoolkit-lib~=1.37
 logzero
 opentracing~=2.2
 opentelemetry-api>=1.15.0