redfishpower: add more details on hierarchy errors #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a power operation cannot be done due to an issue with the hierarchy, a very general "ancestor off" or "ancestor error" is returned. This does not provide alot of detail to users. Update the error message to be of the form cannot perform <op>, dependency <issue> (host=<host>, plug=<plug>) for example cannot perform on, dependency off (host=cmm plug=Enclosure) Update tests for new error message. Fixes chaos#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When a power operation cannot be done due to an issue with the hierarchy, a very general "ancestor off" or "ancestor error" is returned. This does not provide alot of detail to users.
Update the error message to be of the form
cannot perform <op>, dependency <issue> (host=<host>, plug=<plug>)for example
cannot perform on, dependency off (host=cmm plug=Enclosure)Update tests for new error message.
Fixes #153