Save bitvm setup #438
Draft
Save bitvm setup #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekrembal
requested review from
ceyhunsen,
mmtftr,
atacann and
ozankaymak
and removed request for
ceyhunsen and
mmtftr
mmtftr
reviewed
Jan 21, 2025
| txouts.push(TxOut { | ||
| value: Amount::from_sat(660), // TOOD: Hand calculate this | ||
| script_pubkey: intermediate_addr.script_pubkey(), // TODO: Add winternitz checks here | ||
| value: Amount::from_sat(330), // Minimum amount for a taproot output |
There was a problem hiding this comment.
value should be in constants: ASSERT_TX_OUT_AMOUNT
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| // // This part is not working. |
There was a problem hiding this comment.
We should still use a correct verification key, rn we
| kickoff_idx: i32, | ||
| assert_tx_addrs: Vec<Vec<u8>>, | ||
| root_hash: &[u8; 32], | ||
| public_input_wots: Vec<[u8; 20]>, |
There was a problem hiding this comment.
consider impl AsRef<[u8; 20]>
also impl AsRef<[impl AsRef<[u8]>]> (not sure if this works)
| @@ -35,9 +35,9 @@ pub struct WinternitzDerivationPath { | |||
| pub watchtower_idx: Option<u32>, | |||
| pub time_tx_idx: Option<u32>, | |||
| pub kickoff_idx: Option<u32>, | |||
| pub intermediate_step_idx: Option<u32>, | |||
| pub intermediate_step_name: Option<&'a str>, | |||
There was a problem hiding this comment.
Does this have to be a &str? Can it be an enum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390