Skip to content

Conversation

@jfldde
Copy link
Contributor

@jfldde jfldde commented Dec 24, 2025

Description

  • Implements eth_sendRawTransactionSync as per EIP-7966

Linked Issues

@jfldde jfldde requested a review from a team as a code owner December 24, 2025 13:41
@auto-assign auto-assign bot requested a review from ercecan December 24, 2025 13:41
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 53.39806% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.8%. Comparing base (6ed8929) to head (09b52b8).

Files with missing lines Patch % Lines
crates/ethereum-rpc/src/lib.rs 9.4% 48 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/common/src/rpc/eip_7966.rs 100.0% <100.0%> (ø)
crates/common/src/rpc/mod.rs 73.0% <100.0%> (ø)
crates/ethereum-rpc/src/ethereum.rs 100.0% <100.0%> (ø)
crates/ethereum-rpc/src/lib.rs 74.5% <9.4%> (-8.1%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ercecan
ercecan previously approved these changes Jan 5, 2026
Copy link
Member

@ercecan ercecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pub const DEFAULT_TIMEOUT_MS: u64 = 2_000;

/// Maximum allowed timeout in milliseconds. (1min)
pub const MAX_TIMEOUT_MS: u64 = 60_000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this configurable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be passable from RpcConfig but default value is used when env var is not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement eip-7966

5 participants