-
Notifications
You must be signed in to change notification settings - Fork 124
feat: implement eip-7966 #3095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nightly
Are you sure you want to change the base?
feat: implement eip-7966 #3095
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
ercecan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| pub const DEFAULT_TIMEOUT_MS: u64 = 2_000; | ||
|
|
||
| /// Maximum allowed timeout in milliseconds. (1min) | ||
| pub const MAX_TIMEOUT_MS: u64 = 60_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be passable from RpcConfig but default value is used when env var is not found
Description
eth_sendRawTransactionSyncas per EIP-7966Linked Issues