-
Notifications
You must be signed in to change notification settings - Fork 124
feat: Better DB transaction API #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kpp
wants to merge
13
commits into
nightly
Choose a base branch
from
kpp/db_tx_api
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2774d59
Implement LedgerTx with basic ops
kpp f936504
Impl a basic db tx using rocksdb transaction
kpp 669a8ca
Implement rollbacks using db tx
kpp 337ad3f
Implement ledger db writes using SchemaBatch
kpp db9603c
Final schema batch changes
kpp fbb2449
Remove TransactionLedgerDB
kpp d6715c2
Merge branch 'nightly' into kpp/db_tx_api
kpp a91e53e
Fix get_commitment_by_index on fullnode
kpp a2846da
Fix test_out_of_range_proof
kpp 17db27c
Fix tests
kpp 7096c4b
Fix missing doc
kpp b66952b
Refactor the code a little bit
kpp 8071bba
Merge branch 'nightly' into kpp/db_tx_api
kpp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.