Skip to content

Conversation

@anim001k
Copy link

Description

Replace blocking std::fs::write with non-blocking tokio::fs::write in the batch prover RPC module to prevent blocking the Tokio worker thread during file I/O operations.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.8%. Comparing base (3593a8a) to head (a7d12b5).
⚠️ Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/batch-prover/src/rpc.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/batch-prover/src/rpc.rs 91.9% <0.0%> (-0.9%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eyusufatik
eyusufatik previously approved these changes Oct 14, 2025
jfldde
jfldde previously approved these changes Oct 17, 2025
@anim001k
Copy link
Author

@eyusufatik is it ok to be merged?

@kpp
Copy link
Contributor

kpp commented Oct 30, 2025

Please resolve conflicts

@anim001k anim001k dismissed stale reviews from jfldde and eyusufatik via 15f75ff October 30, 2025 08:57
@anim001k
Copy link
Author

Please resolve conflicts

@kpp resolved

jfldde
jfldde previously approved these changes Oct 30, 2025
Copy link
Contributor

@jfldde jfldde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for the nit

@jfldde jfldde requested a review from a team as a code owner November 29, 2025 15:04
@anim001k
Copy link
Author

@eyusufatik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants