-
Notifications
You must be signed in to change notification settings - Fork 124
perf(batch-prover): replace blocking fs::write with async tokio::fs::write #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nightly
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
|
@eyusufatik is it ok to be merged? |
|
Please resolve conflicts |
@kpp resolved |
jfldde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for the nit
Description
Replace blocking
std::fs::writewith non-blockingtokio::fs::writein the batch prover RPC module to prevent blocking the Tokio worker thread during file I/O operations.