Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core dependencies #1518

Merged
merged 83 commits into from
Dec 18, 2024
Merged

Update core dependencies #1518

merged 83 commits into from
Dec 18, 2024

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Nov 25, 2024

Updates
Reth: 1.0.4 -> 1.1.0
Revm: 12.1 -> 14.0.3
revm-primitives: 8 -> 10.0.0
alloy: 0.2.1 -> 0.4.2
alloy-core deps 0.7.x -> 0.8.x

  • Uses rlp encoding for storage, because with rlp encoding we will have future proof serializations and deserializations

Closes #1523
Closes #1292
Closes #1529

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 73.72549% with 134 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (7e1480b) to head (9ae424f).

Files with missing lines Patch % Lines
crates/sequencer/src/db_provider/mod.rs 7.3% 88 Missing ⚠️
crates/ethereum-rpc/src/gas_price/gas_oracle.rs 16.6% 15 Missing ⚠️
crates/evm/src/evm/primitive_types.rs 93.3% 12 Missing ⚠️
crates/ethereum-rpc/src/gas_price/cache.rs 57.1% 3 Missing ⚠️
crates/ethereum-rpc/src/lib.rs 25.0% 3 Missing ⚠️
crates/ethereum-rpc/src/trace.rs 0.0% 3 Missing ⚠️
crates/evm/src/rpc_helpers/tracing_utils.rs 40.0% 3 Missing ⚠️
crates/evm/src/query.rs 98.3% 2 Missing ⚠️
crates/sequencer/src/deposit_data_mempool.rs 0.0% 2 Missing ⚠️
crates/evm/src/evm/system_contracts/mod.rs 0.0% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
Files with missing lines Coverage Δ
crates/batch-prover/src/runner.rs 86.0% <ø> (-0.3%) ⬇️
crates/common/src/da.rs 96.8% <ø> (+1.5%) ⬆️
crates/ethereum-rpc/src/ethereum.rs 100.0% <ø> (ø)
crates/ethereum-rpc/src/gas_price/fee_history.rs 98.6% <100.0%> (ø)
crates/ethereum-rpc/src/subscription.rs 100.0% <100.0%> (ø)
crates/evm/src/call.rs 98.3% <100.0%> (+<0.1%) ⬆️
crates/evm/src/evm/call.rs 92.4% <ø> (ø)
crates/evm/src/evm/conversions.rs 98.0% <100.0%> (ø)
crates/evm/src/evm/db.rs 85.7% <100.0%> (ø)
crates/evm/src/evm/db_init.rs 57.6% <ø> (ø)
... and 33 more

... and 2 files with indirect coverage changes

@ercecan ercecan added the FORK This ticket needs a fork label Nov 27, 2024
@ercecan ercecan changed the title Erce/update core dependencies Update core dependencies Dec 12, 2024
@ercecan ercecan linked an issue Dec 17, 2024 that may be closed by this pull request
@ercecan ercecan removed the HOLD-MERGE PR is not draft but should not be merged yet label Dec 17, 2024
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open issue for unnecessary double hashing for rlp decode header

@eyusufatik eyusufatik merged commit e8c5647 into nightly Dec 18, 2024
12 of 14 checks passed
@eyusufatik eyusufatik deleted the erce/update-core-dependencies branch December 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FORK This ticket needs a fork
Projects
None yet
3 participants