Invalidate Soft Confirmation on sov-module errors #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
any failing (I don't mean reverting here, failing) evm tx would make the soft confirmation invalid.
The way I handled the hash bug fix should be changed into a better one imo.
At the beginning of the project we thought when we enabled forced transactions we would need to run them along soft confirmations. However, they can be treated differently. All the workaround and ignoring errored transactions makes a lot of stuff much harder. e.g. we have to have weird workaround accessory maps for block bulding etc.
Another goal of this pr is to fix error handling and propogation in the STF
Closes #1438
Closes #1061 (not impl. yet)
Closes #1048 (not impl. yet)