-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded elf guests for forks #1495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakanalh
commented
Nov 20, 2024
bc84b7f
to
cbaaa8e
Compare
cbaaa8e
to
1faef96
Compare
eyusufatik
reviewed
Nov 20, 2024
btw just pass down elf from runner > prover service > zkvm host I think bonsai doesnt upload all the time since it checks if elf exists on remote |
1 task
ef82dd3
to
8db236d
Compare
eyusufatik
approved these changes
Dec 2, 2024
yaziciahmet
reviewed
Dec 2, 2024
yaziciahmet
reviewed
Dec 2, 2024
yaziciahmet
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! not blocking the pr, just have 1 comment.
yaziciahmet
approved these changes
Dec 2, 2024
eyusufatik
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make build
now builds the ELF guest codes separately usingmake build-risc0
andmake build-sp1
.This basically removes the fact that we build the guest code along with the binary. Now, the guest code is loaded from
resources/guests
based on what we want to load.That being said, each fork should add the ELF to the designated directory with
1.elf
,2.elf
.. etc for each fork we end up introducing. The names can change of course but that's how it goes for now.Development workflow
Previously, we used to have the guest code already built within the binary. If you run:
make build
make test
Both will act the same way by building the guest code and provide a binary that has the guest codes needed.
If you are running testing a specific build for the guest code, you can use:
make -C guests/risc0 batch-proof-bitcoin
make -C guests/risc0 batch-proof-mock
make -C guests/risc0 light-client-bitcoin
make -C guests/risc0 light-client-mock
TODO
build.rs
for risc0 from running.network
if--testnet
is used.Network
argumentLinked Issues