Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erce/update core dependencies #1518

Open
wants to merge 69 commits into
base: nightly
Choose a base branch
from
Open

Erce/update core dependencies #1518

wants to merge 69 commits into from

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Nov 25, 2024 •
edited
Loading

Updates
Reth: 1.0.4 -> 1.1.0
Revm: 12.1 -> 14.0.3
revm-primitives: 8 -> 10.0.0
alloy: 0.2.1 -> 0.4.2
alloy-core deps 0.7.x -> 0.8.x

Closes #1523 #1292

@ercecan
Update reth versions
b693f6c
@ercecan
Remove reth rpc types as it does not exist anymore
f0a56b1
@ercecan
Update alloy versions
1ca1960
@ercecan
Fix calc next block base fee
11c8a09
@ercecan
Fix sequencer client
fd14f63
@ercecan
Sequencer client compiles
d061535
@ercecan
Remove unnecessary deps from citrea primitives
6e8e3de
@ercecan
Update revm versions
700b2ca
@ercecan
Rename bridge helper struct to bridge wrapper
536ace0
@ercecan
Use alloy primitives instead of reth primitives where required
0c7550b
@ercecan
Typo fix
8471845
@ercecan
Slowly getting rid of reth rpc types and reth primitives
a8d4070
@ercecan
Temp solution to non const system signature creation
40dc05c
@ercecan
Use decode instead of decode enveloped in TransactionSignedNoHash con…
f5c62f4 
…version
@ercecan
Fix return type of journaled state load account
75a0e86
@ercecan
Use evm errors from reth directly instead of copying and pasting in o…
5be5a1d 
…ur code
@ercecan
Update sealed block
258cf2d
@ercecan
More evm fixes
d24568a
@ercecan
Make account mutable
bdd792e
@ercecan
Add new tracer type
951e780
@ercecan
Fix get block by number rpc
b208946
@ercecan
Fix get block by hash rpc
0f7bbf9
@ercecan
Fix get_transaction_by_block_hash_and_index rpc
5092945
@ercecan
Fix get_transaction_by_block_number_and_index rpc
036f305
@ercecan
Fix wrong fields
b01924c
@ercecan
Get rid of unknownblocknumber in query rs
366ab82
@ercecan
Fix all query rs errors
3633520
@ercecan
Evm compiles
617ed99
@ercecan
Fix cahce rs in eteherum rpc
e706bd8
@ercecan
Fix fee history in ethereum rpc
0d1aca5
@ercecan ercecan marked this pull request as ready for review November 26, 2024 14:23
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.87912% with 106 lines in your changes missing coverage. Please review.

Project coverage is 76.7%. Comparing base (0494407) to head (5e8ec8c).
Report is 2 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/sequencer/src/db_provider/mod.rs 7.3% 88 Missing ⚠️
crates/ethereum-rpc/src/gas_price/gas_oracle.rs 77.7% 4 Missing ⚠️
crates/ethereum-rpc/src/lib.rs 25.0% 3 Missing ⚠️
crates/ethereum-rpc/src/trace.rs 0.0% 3 Missing ⚠️
crates/evm/src/rpc_helpers/tracing_utils.rs 40.0% 3 Missing ⚠️
crates/evm/src/query.rs 98.3% 2 Missing ⚠️
crates/sequencer/src/deposit_data_mempool.rs 0.0% 2 Missing ⚠️
crates/evm/src/evm/system_contracts/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/ethereum-rpc/src/ethereum.rs 100.0% <ø> (ø)
crates/ethereum-rpc/src/gas_price/cache.rs 95.1% <100.0%> (ø)
crates/ethereum-rpc/src/gas_price/fee_history.rs 98.6% <100.0%> (ø)
crates/ethereum-rpc/src/subscription.rs 100.0% <100.0%> (ø)
crates/evm/src/call.rs 96.1% <100.0%> (+<0.1%) ⬆️
crates/evm/src/evm/call.rs 92.4% <ø> (ø)
crates/evm/src/evm/conversions.rs 98.0% <100.0%> (ø)
crates/evm/src/evm/db.rs 75.2% <100.0%> (ø)
crates/evm/src/evm/db_init.rs 57.6% <ø> (ø)
crates/evm/src/evm/handler.rs 78.2% <100.0%> (ø)
... and 28 more

... and 10 files with indirect coverage changes

@ercecan ercecan added the FORK This ticket needs a fork label Nov 27, 2024
@eyusufatik eyusufatik mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik Awaiting requested review from eyusufatik

@jfldde jfldde Awaiting requested review from jfldde

@kpp kpp Awaiting requested review from kpp

@rakanalh rakanalh Awaiting requested review from rakanalh

@yaziciahmet yaziciahmet Awaiting requested review from yaziciahmet

At least 1 approving review is required to merge this pull request.

Assignees

@ercecan ercecan

Labels
FORK This ticket needs a fork HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove fn convert_u64_to_u256
3 participants
@ercecan @kpp @eyusufatik