Skip to content

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Apr 22, 2025

I have no idea if this breaks otehr stuff, but it fixed the issue for me.

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

I have no idea if this breaks otehr stuff, but it fixed the issue for me.

Signed-off-by: Dan Lorenc <[email protected]>
@jonjohnsonjr
Copy link
Contributor

jonjohnsonjr commented Apr 22, 2025

We used to have a list of xattrs to ignore: https://github.com/chainguard-dev/melange/pull/1836/files#diff-63400ef9a478817b5659a4b2dac0231e96bfbff58a5ced18be996aac50ba44a5

Should we have an allowlist?

@egibs
Copy link
Member

egibs commented Apr 22, 2025

We used to have a list of xattrs to ignore: #1836 (files)

Should we have an allowlist?

I don't mind re-adding the allowlist since I rm'd the original functionality.

@egibs
Copy link
Member

egibs commented Apr 25, 2025

@dlorenc -- does melange 0.23.10 fix the issues you were seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants