c++ 20 cleanups #94
Draft
c++ 20 cleanups #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanofsky
added a commit
that referenced
this pull request
Jun 13, 2024
537c645 doc: Improve ProxyServerCustom class documentation (Ryan Ofsky) d4d9f93 doc: Document FunctionTraits/ProxyMethodTraits classes (Ryan Ofsky) 78c7dd0 doc: Document ProxyClient construct/destroy methods (Ryan Ofsky) e99c0b7 doc: Document clientInvoke/serverInvoke functions (Ryan Ofsky) 2098ae1 doc: Add comment on serverInvoke ReplaceVoid usage (Ryan Ofsky) a1dfb0b doc: Add comments to mp.Context PassField function on updating g_thread_context (Ryan Ofsky) e49a925 doc: Add comments to mp.Context PassField function on mp.Context.thread lookup (Ryan Ofsky) Pull request description: Add code comments and documentation. Most of these comments were originally added as part of #94 but are being moved to a separate PR so they can be merged sooner Top commit has no ACKs. Tree-SHA512: 284325513d3244313a4ff54ed20648061a6142ce89f4449bb046938780f1d74c7691dba5fdff5f478f585e95e5ea0987af2fde2e67c049adc8a6b7db21371341
Also add comments to explain code using it the PassField proxy.capnp Context overload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be a lot of places where new C++ features can be used to simplify code, particularly concept features in C++20 so I'm starting to go through code and look for places where it can be modernized. Will collect the smaller cleanups in this PR and probably open other PRs with bigger cleanups.