-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Introduce Libmultiprocess_INSTALL_PKGCONFIG_FILE
build option
#112
base: master
Are you sure you want to change the base?
Conversation
configure_file(pkgconfig/libmultiprocess.pc.in "${CMAKE_CURRENT_BINARY_DIR}/pkgconfig/libmultiprocess.pc" @ONLY) | ||
install(FILES "${CMAKE_CURRENT_BINARY_DIR}/pkgconfig/libmultiprocess.pc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the pkgconfig
subdirectory seems redundant here, no?
Is there a particular reason to not install it by default? Note that |
This change makes the installation of the `pkgconfig/libmultiprocess.pc` file optional.
39aa7ea
to
f8eea25
Compare
The default value of the new option has been changed to |
What's the motivation for this change? It seems like an unusual thing for a package to have a configuration option to not fully install itself. And if installing a .pc file is optional, should installing .cmake package files be optional also? I think I'd prefer the cmake code here to be as vanilla as possible and not have a non-standard option like this, unless there is a real reason why it's useful. Also it seems would seem better to just use cmake components to control what is installed instead of using both cmake components and cmake options to control what is installed. Maybe installed metadata files could be moved into different components to provide finer-grained control over what to install if this is necessary. |
Currently, the package built in Bitcoin Core depends looks like that:
The |
This PR makes the installation of the
pkgconfig/libmultiprocess.pc
file optional.