Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design implementation for responsive navigation #10

Closed
6 tasks
Tracked by #273
natalia-fitzgerald opened this issue Oct 17, 2024 · 1 comment
Closed
6 tasks
Tracked by #273
Assignees
Labels
design review Review implementation of designs in development

Comments

@natalia-fitzgerald
Copy link
Collaborator

natalia-fitzgerald commented Oct 17, 2024

Task

Design review for responsive navigation

Context

  • Mobile nav items: [Home] [Filing] [Profile (links to the user's profile)] [Log out]
  • Selected is black vertical line (at desktop this line is horizontal)
  • Hover is green vertical line (at desktop this line is horizontal)
  • Line above and below each link is Gray 40
  • Use of hamburger to show navigation (pull from cf.gov implementation)
  • Use of "x" to hide navigation (pull from cf.gov implementation)

Here's a mock-up:

Updated on 6/27/2024 (I may need to update the mock-ups to the latest):
Screenshot 2024-06-27 at 4 19 47 PM
Loosely based on the consumerfinance.gov mobile megamenu. Let's pull the code that we can. https://www.consumerfinance.gov

@natalia-fitzgerald
Copy link
Collaborator Author

natalia-fitzgerald commented Oct 30, 2024

@angelcardoz
I have reviewed this in dev pub and the PR has been merged. This will be included in work that will be merged into beta next week.

I did find some issues in my review but we decided to move those to a separate task since they are not strictly related to the mobile navigation.

This is the separate task:
Improvements to platform navigation menu #1033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design review Review implementation of designs in development
Projects
None yet
Development

No branches or pull requests

1 participant