Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unit Test] Write Component Unit Tests #1110

Merged
merged 6 commits into from
Jan 24, 2025
Merged

[Unit Test] Write Component Unit Tests #1110

merged 6 commits into from
Jan 24, 2025

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Jan 14, 2025 •
edited
Loading

Components needed unit tests so some unit tests have been written.

Changes

  • Updated vite config to facilitate in IDE running of tests
  • Wrote tests for the following component files
    • ScreenReaderOnly
    • ScrollToTop
    • SectionIntro.tsx
    • TextInput.tsx
    • WarningErrorIcon.tsx

How to test this PR

  1. Pull the branch for this PR
  2. Navigate to the sbl-frontend directory
  3. run yarn run vitest
  4. Verify that the coverage is 100% across the board for the above files mentioned

@tanner-ricks tanner-ricks linked an issue Jan 14, 2025 that may be closed by this pull request
[Unit Test] Write Component Unit Tests #1092
Closed
@tanner-ricks tanner-ricks changed the title DRAFT: [Unit Test] Write Component Unit Tests [Unit Test] Write Component Unit Tests Jan 15, 2025
@tanner-ricks tanner-ricks marked this pull request as ready for review January 15, 2025 19:40
meissadia
meissadia approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏾

@tanner-ricks tanner-ricks enabled auto-merge (squash) January 24, 2025 16:28
@tanner-ricks tanner-ricks disabled auto-merge January 24, 2025 17:39
@tanner-ricks tanner-ricks merged commit f0ad871 into main Jan 24, 2025
10 of 11 checks passed
@tanner-ricks tanner-ricks deleted the 1092-component-unit-tests branch January 24, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unit Test] Write Component Unit Tests
2 participants
@tanner-ricks @meissadia