This repository has been archived by the owner on Sep 17, 2018. It is now read-only.
add missing trailing slash #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a good time to s/127.0.0.0/127.0.0.1 as well |
|
Good catch @cmc333333 . Added. |
| @@ -37,7 +37,7 @@ tweaked to pass the parser. | |||
| 1. `cd regulations-parser` | |||
| 1. `git clone https://github.com/cfpb/fr-notices.git` | |||
| 1. `pip install -r requirements.txt` | |||
| 1. `echo "LOCAL_XML_PATHS = ['fr-notices']" >> local_settings.py` | |||
| 1. `echo "LOCAL_XML_PATHS = ['fr-notices/']" >> local_settings.py` | |||
There was a problem hiding this comment.
Does it make sense to add a note here about how that trailing slash is required?
Also, might be useful to put in an issue somewhere about removing the need for the trailing slash.
There was a problem hiding this comment.
It probably does, but not in the quick start section since it is basically a list of copy and paste-able instructions.
|
Looks good to me 👍 Did you want to take care of #273 before merging, or should we do that in another PR? |
|
I vote for merging before we do anything about #273. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing trailing slash in the Quick Start section and removes some trailing whitespace