Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for exception detail to be shown as objects #162

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

lchen-2101
Copy link
Collaborator

closes #161

Copy link

github-actions bot commented Dec 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/regtech_api_commons/api
  exception_handlers.py
  exceptions.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will the frontend need to know about the possibility of json being there versus just a string? Or is this already handled on their end?

@lchen-2101
Copy link
Collaborator Author

LGTM. Will the frontend need to know about the possibility of json being there versus just a string? Or is this already handled on their end?

They aren't using the detail of the exception yet, purely status code at the moment. How the error details will be used still up in the air, but we should coordinate with front end soon. I'll bring it up tomorrow during standup.

@lchen-2101 lchen-2101 merged commit 8fc3a94 into main Dec 4, 2024
5 of 6 checks passed
@lchen-2101 lchen-2101 deleted the feature/161_allow_exception_detail_objects branch December 4, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update exception handler to respond with objects in exception detail
2 participants