Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wscript javascript bundle #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stef-levesque
Copy link

fixes build error on SDK 4.3 about 'task_gen' object has no attribute 'js_entry_file'

fixes build error on SDK 4.3 about 'task_gen' object has no attribute 'js_entry_file'
@v6ak
Copy link

v6ak commented Nov 22, 2017

I've tried to apply it (because I've tried to enhance the C code in #4). It works better than my attempt to fix the build, but it is still not perfect. I see name M7S_wf_15_7 and no screenshot. Do you have any idea how to fix it?

@stef-levesque
Copy link
Author

@v6ak sry, I haven't looked at pebble development in a while. I'm not familiar with the recent SDK changes.

@v6ak
Copy link

v6ak commented Dec 27, 2017

Well, it seems like the cause is quite different. It looks like name and screenshot is not part of the repository. It probably comes from the store. So, your PR is probably OK.

@daktak
Copy link

daktak commented May 27, 2020

Confirmed, screenshot comes from the rebble store

@srimanth-yarlagadda
Copy link

Well, it seems like the cause is quite different. It looks like name and screenshot is not part of the repository. It probably comes from the store. So, your PR is probably OK.

Hi, can I ask how this issue was fixed. I am running SDK on docker and getting exact error on issuing a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants