Open
Conversation
|
The preview deployment failed. 🔴 Last updated at: 2025-08-20 21:01:10 CET |
joaodiaslobo
requested review from
diogogmatos,
enricoprazeres,
filipapeixoto25 and
gxnca
enricoprazeres
requested changes
Jul 10, 2025
Member
enricoprazeres
left a comment
enricoprazeres
left a comment
There was a problem hiding this comment.
Also, there could be cases when there is only an icon with no text, and for screen readers it is bad because they rely on the text to narrate the content of the page to the user. Consider adding another prop for the ariaLabel, and add it to the button/link directly.
aria-label={ariaLabel}
enricoprazeres
requested changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2
Some usage examples: