Skip to content

Add certificate verification process to filter CAs only #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arsenalzp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add certificate verification process to filter CAs only #824

arsenalzp wants to merge 1 commit into from

Conversation

@arsenalzp
Copy link
Contributor

@arsenalzp arsenalzp commented Dec 20, 2025

This PR closes #797.
Changes bring new API feature which allows filtering non-CA certificates in sources.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 20, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Dec 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Dec 20, 2025

Hi @arsenalzp. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2025
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2025
@arsenalzp
Copy link
Contributor Author

arsenalzp commented Dec 21, 2025

/ok-to-test

@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Dec 21, 2025

@arsenalzp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@erikgb
Copy link
Member

erikgb commented Dec 21, 2025

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2025
@arsenalzp
Copy link
Contributor Author

arsenalzp commented Dec 21, 2025

I've just fixed the API definition and related tests.

@arsenalzp
add API CA certs only feature
c8013d3 
Signed-off-by: Oleksandr Krutko <[email protected]>
@arsenalzp arsenalzp changed the title Add a verification the certificate is a CA certificate Add a verification the certificate is the CA one Jan 5, 2026
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2026
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 7, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maelvls maelvls requested a review from erikgb January 8, 2026 17:45
@arsenalzp
Copy link
Contributor Author

arsenalzp commented Jan 12, 2026

Hello colleagues @erikgb @inteon @SgtCoDFish
Could you please review this PR?

@arsenalzp arsenalzp changed the title Add a verification the certificate is the CA one Add certificate verification process to filter CAs only Jan 12, 2026
@erikgb
Copy link
Member

erikgb commented Jan 12, 2026

Could you please review this PR?

@arsenalzp, it's on my list. Could you please rebase and resolve conflicts!

@arsenalzp
Copy link
Contributor Author

arsenalzp commented Jan 12, 2026

Sure, I will rebase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb Awaiting requested review from erikgb

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a verification the certificate is a CA certificate

2 participants

@arsenalzp @erikgb