fix(records): change DELPHI record 91396 to use file indices #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
force-pushed
the
delphi_index
branch
from
cc3c3cf to
1abea12
Compare
tiborsimko
changed the title
tiborsimko
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Works nicely 👍
This change has been checked with @dietrichliko and @schwicke. The motivation being that the given MC record contains many individual files with the same base name, only stored in different subdirectories, which is something that the portal infrastructure currently does not support. And, the file-index based browsing is actually useful for an MC record consisting of so many files anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ries directly attached to the record
Closes #3717