CMakeLists: Skip CheckGcc107852

as fmt::fmt is introduced to Ceph by including {fmt} project as a subdirectory, and it is not an alias of a global library. CheckGcc107852 is not able to find fmt::fmt. as workaround, comment out the checks and apply the relevant CXXFLAGS. Co-authored-by: Kefu Chai <[email protected]> Signed-off-by: Matan Breizman <[email protected]> Signed-off-by: Matan Breizman <[email protected]>
ceph · Jul 7, 2024 · 3dc415a · 3dc415a
1 parent 79fde4b
commit 3dc415a
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -803,13 +803,16 @@ set (Seastar_PRIVATE_CXX_FLAGS
   -Wdeprecated
   -Wno-error=deprecated)
 
-if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-  include (CheckGcc107852)
-  if (NOT Cxx_Compiler_BZ107852_Free)
+if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND
+    FMT_VERSION VERSION_LESS 10.1.1 AND
+    CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 13.0.0)
+    # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107852
+  # include (CheckGcc107852)
+  # if (NOT Cxx_Compiler_BZ107852_Free)
     list (APPEND Seastar_PRIVATE_CXX_FLAGS
       -Wno-error=stringop-overflow
       -Wno-error=array-bounds)
-  endif ()
+  # endif ()
   list (APPEND Seastar_PRIVATE_CXX_FLAGS
     -Wdeprecated-declarations
     -Wno-error=deprecated-declarations)