fix #83, and change events like https://github.dev/centrifugal/centri…

[hetao29]

change dart events like https://github.dev/centrifugal/centrifuge-java @FZambia

[FZambia]

Hello, @hetao29 - please revert 16a13c3 - I'll investigate CI issue, but the code you removed is generally useful - it's required for package to work in web environment.

[FZambia]

@hetao29 hello, I fixed CI issue in terms of #85 - could you please rebase to master? Or simply open new PR - whatever you prefer.

[hetao29]

@hetao29 hello, I fixed CI issue in terms of #85 - could you please rebase to master? Or simply open new PR - whatever you prefer.

merged.

[FZambia]

We need to keep backwards compatibility of event fields - so instead of removing user and client we need to extend events with connInfo and chanInfo.

[hetao29]

Personally, I think it is really important to maintain compatibility, but the interface unity of the external output SDK is also very critical. In this SDK, client and user are different from other languages. It feels like it is more superfluous, so after referring to other After installing the sdk, I decided to delete it directly instead of simply adding an info

[FZambia]

I mean events should be like this:

class JoinEvent {
  ...

  final String client;
  final String user;
  final List<int>? connInfo;
  final List<int>? chanInfo;
  
  ...
}  

This will allow us releasing new version of centrifuge-dart and not break other users' code upon upgrade. We can break compatibility if there is enough reasoning for it - but in this case it seems we can simply extend current events with new optional fields from ClientInfo. Or having final ClientInfo info; simplifies sth for your use case to justify breaking change at this point?

BTW: you are exposing proto.ClientInfo now, but we have another ClientInfo in events.dart to not export Protobuf structures to library users directly. See ClientInfo

[hetao29]

OK, cool, I'll repush later...

[FZambia]

Many thanks 👍