Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epochs:send-validator-payment command #510

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

shazarre
Copy link
Contributor

@shazarre shazarre commented Jan 15, 2025

Description

This PR adds epochs:send-validator-payment command to distribute validator epoch payments.

Other changes

Exposed needed contract methods on EpochManager wrapper.

Tested

Ran tests locally.

How to QA

Ran tests locally and ran the command, successfully sent a transaction.

Related issues


PR-Codex overview

This PR introduces the sendValidatorPayment method in the EpochManager contract wrapper and adds a CLI command to facilitate sending epoch payments to validators, their groups, and delegation beneficiaries. It also includes tests for the new functionality.

Detailed summary

  • Added sendValidatorPayment method in EpochManager wrapper.
  • Introduced epochs:send-validator-payment CLI command.
  • Updated documentation for sendValidatorPayment method.
  • Enhanced tests to cover successful payment sending and validation checks.
  • Modified existing tests to include payment distribution verification.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@shazarre shazarre self-assigned this Jan 15, 2025
@shazarre shazarre requested a review from a team as a code owner January 15, 2025 11:22
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: bfc818e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@celo/contractkit Patch
@celo/celocli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.39%. Comparing base (f76274f) to head (bfc818e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   76.31%   76.39%   +0.07%     
==========================================
  Files         246      247       +1     
  Lines       10386    10421      +35     
  Branches     1639     1633       -6     
==========================================
+ Hits         7926     7961      +35     
- Misses       2373     2401      +28     
+ Partials       87       59      -28     
Components Coverage Δ
celocli 86.68% <100.00%> (+0.11%) ⬆️
sdk 68.96% <100.00%> (+<0.01%) ⬆️
wallets 73.30% <ø> (ø)
viem-sdks 95.08% <ø> (ø)

@shazarre shazarre enabled auto-merge (squash) January 22, 2025 11:18
@shazarre shazarre merged commit 0d307db into master Jan 22, 2025
22 of 37 checks passed
@shazarre shazarre deleted the shazarre/epochs_send_validator_payment_command branch January 22, 2025 11:35
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
aaronmgdr pushed a commit that referenced this pull request Jan 31, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`master` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `master`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @celo/[email protected]

### Minor Changes

- [#511](#511)
[`be62336`](be62336)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
useSafe flags for governance:propose and governance:withdraw commands

- [#510](#510)
[`0d307db`](0d307db)
Thanks [@shazarre](https://github.com/shazarre)! - Add
`epochs:send-validator-payment` command to support sending validator,
their group and delegation beneficiary allocated epoch payments

### Patch Changes

- [#514](#514)
[`4a1d9e7`](4a1d9e7)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix bug with
GovernanceSlasher missing version causing failure. defend against
exceptions when printing contracts info

- Updated dependencies
\[[`0d307db`](0d307db),
[`a8e5099`](a8e5099)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Minor Changes

- [#516](#516)
[`a8e5099`](a8e5099)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
(Beta) support for signTypedData in @celo/viem-account-ledger and
@celo/wallet-ledger when using with the `ethereum` ledger app.
    when using with the `ethereum` ledger app.

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Minor Changes

- [#516](#516)
[`a8e5099`](a8e5099)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
(Beta) support for signTypedData in @celo/viem-account-ledger and
@celo/wallet-ledger when using with the `ethereum` ledger app.
    when using with the `ethereum` ledger app.

## @celo/[email protected]

### Patch Changes

- [#510](#510)
[`0d307db`](0d307db)
Thanks [@shazarre](https://github.com/shazarre)! - Expose
`sendValidatorPayment` methods for `EpochManager` contract wrapper

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]



## @celo/[email protected]




<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various packages to version `7.0.0-beta.1`
and `9.0.1-beta.1`, along with minor changes and dependency updates
across the Celo SDK and related libraries.

### Detailed summary
- Updated versions in `CHANGELOG.md` for multiple packages to
`7.0.0-beta.1`.
- Updated `@celo/wallet-base` version to `7.0.0-beta.1` in several
`package.json` files.
- Added new entries in `CHANGELOG.md` for `@celo/viem-account-ledger`
and `@celo/contractkit`.
- Introduced minor changes in `@celo/celocli` and `@celo/wallet-ledger`
with new commands and features.
- Updated dependencies for multiple packages to reflect the new
versions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cli command for sendValidatorPayment
3 participants