New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO-104076 | fix max call stack error #3

Merged

sandeepkumarcel merged 1 commit into celigo:master from sandeepkumarcel:IO-104076

Dec 3, 2024

Collaborator

sandeepkumarcel commented Nov 20, 2024 •

edited

Loading

    -- records.push(...recordBatch.records)
    ++ for(let i = 0; i < recordBatch.records.length; i++) {
      records.push(recordBatch.records[i])
    }
    
    a large records  size (> 125k) causes the spread operator to use all of the stack and cause max call stack size error, converting it to regular for loop for better performace

ci check passed in original repo: tulios#1723


          fix max call stack error

4bb53ee

vinaykhebbar approved these changes

View reviewed changes

sandeepkumarcel merged commit f68b973 into celigo:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet