fix: tx client concurrency test #4104
Conversation
cmwaters
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
📝 WalkthroughWalkthroughThe pull request introduces modifications to two files in the Changes
Sequence DiagramsequenceDiagram
participant Test as TestConcurrentTxSubmission
participant TxClient as Transaction Client
participant Mempool as Mempool
Test->>TxClient: Submit 100 Transactions
TxClient->>Mempool: Send Transactions
Mempool-->>TxClient: Process Transactions
alt Transaction Eviction
Mempool->>TxClient: Evict Transaction
TxClient->>TxClient: Manage Sequence
end
alt Context Cancellation
TxClient->>TxClient: Check Context Status
TxClient-->>Test: Return Cancellation Error
end
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/user/e2e_test.go (1)
36-36: Consider parameterizing the number of transactions.While increasing the test load is good for stress testing, consider making
numTxsconfigurable through a test parameter or environment variable. This would allow for quick tests during development while maintaining the ability to run more extensive tests in CI.- numTxs := 100 + numTxs := getTestTxCount() // Add this helper function: +func getTestTxCount() int { + if count, err := strconv.Atoi(os.Getenv("TEST_TX_COUNT")); err == nil { + return count + } + return 100 // default to 100 +}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pkg/user/e2e_test.go(1 hunks)pkg/user/tx_client.go(1 hunks)
🔇 Additional comments (2)
pkg/user/e2e_test.go (1)
42-42: Good fix: Buffered error channel prevents goroutine leaks.
The addition of buffer capacity to errCh is a crucial fix. Previously, if multiple errors occurred simultaneously, the error channel being unbuffered could cause goroutine leaks as the first error might not be read before subsequent errors tried to write to the channel.
pkg/user/tx_client.go (1)
466-468: Good addition: Proper context cancellation handling.
The addition of the context error check ensures that user-initiated cancellations are properly propagated instead of being masked by the "transaction not found" error. This maintains the correct error semantics and helps with debugging.
There was a problem hiding this comment.
TestConcurrentTxSubmission fails in CI: https://github.com/celestiaorg/celestia-app/actions/runs/12430560032/job/34706233115?pr=4104#step:4:39
Is it a flake? I just retried
This PR makes two small tweaks:
TestConcurrentTxSubmissionby adding a capacity of 1 to the errCh. Currently errors were being ignored because the wait group meant that there wasn't a process to read to the channel as it was being written to. This fixes thisConfirmTxThis test is broken until celestiaorg/celestia-core#1553 is resolved